Make example to use certificate bundle #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To easy maintenance, makes the example on websocket client to use certificate bundle by default.
euripedesrocha
force-pushed
the
ws_example_certificate_bundle
branch
from
0b8352a to
a9f42e3
Compare
Comment on lines
+149
to
+156
| #if CONFIG_WS_OVER_TLS_SERVER_AUTH || CONFIG_WS_OVER_TLS_MUTUAL_AUTH | ||
| // Using certificate bundle as default server certificate source | ||
| websocket_cfg.crt_bundle_attach = esp_crt_bundle_attach; | ||
| // If using a custom certificate it could be added to certificate bundle, added to the build simmilar to client certificates in this examples, | ||
| // or read from NVS. | ||
| /* extern const char cacert_start[] asm("ADDED_CERTIFICATE"); */ | ||
| /* websocket_cfg.cert_pem = cacert_start; */ | ||
| #endif |
There was a problem hiding this comment.
we can attach the self signed cert to the bundle, but I'd suggest reverting this and setting up the bundle in the block below.
Suggested change
| #if CONFIG_WS_OVER_TLS_SERVER_AUTH || CONFIG_WS_OVER_TLS_MUTUAL_AUTH | |
| // Using certificate bundle as default server certificate source | |
| websocket_cfg.crt_bundle_attach = esp_crt_bundle_attach; | |
| // If using a custom certificate it could be added to certificate bundle, added to the build simmilar to client certificates in this examples, | |
| // or read from NVS. | |
| /* extern const char cacert_start[] asm("ADDED_CERTIFICATE"); */ | |
| /* websocket_cfg.cert_pem = cacert_start; */ | |
| #endif |
This way we'd use the bundle only for connecting to the public broker.
Comment on lines
-161
to
-163
| #elif CONFIG_WS_OVER_TLS_SERVER_AUTH | ||
| extern const char cacert_start[] asm("_binary_ca_certificate_public_domain_pem_start"); // CA cert of wss://echo.websocket.event, modify it if using another server | ||
| websocket_cfg.cert_pem = cacert_start; |
There was a problem hiding this comment.
Suggested change
| #elif CONFIG_WS_OVER_TLS_SERVER_AUTH | |
| extern const char cacert_start[] asm("_binary_ca_certificate_public_domain_pem_start"); // CA cert of wss://echo.websocket.event, modify it if using another server | |
| websocket_cfg.cert_pem = cacert_start; | |
| #elif CONFIG_WS_OVER_TLS_SERVER_AUTH | |
| websocket_cfg.crt_bundle_attach = esp_crt_bundle_attach; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To easy maintenance, makes the example on websocket client to use certificate bundle by default.