Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modem]: Add ability to change ESP_MODEM_C_API_STR_MAX from Kconfig (IDFGH-13667) #648

Closed
wants to merge 1 commit into from

Conversation

embedcat
Copy link
Contributor

Description

This PR introduce ability to change ESP_MODEM_C_API_STR_MAX from Kconfig (idf.py menuconfig).

In esp_modem in C-API there is ESP_MODEM_C_API_STR_MAX which defines max size of AT response returned to user.
There is no obvious way to increase this size. Some workaround was found in #184, but I think use Kconfig option is more clear and straightforward.

Related

#184
#624

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kip seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@embedcat embedcat changed the title [modem ] Add ability to change ESP_MODEM_C_API_STR_MAX from Kconfig [modem]: Add ability to change ESP_MODEM_C_API_STR_MAX from Kconfig Sep 11, 2024
@github-actions github-actions bot changed the title [modem]: Add ability to change ESP_MODEM_C_API_STR_MAX from Kconfig [modem]: Add ability to change ESP_MODEM_C_API_STR_MAX from Kconfig (IDFGH-13667) Sep 11, 2024
@embedcat embedcat closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants