Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modem]: Add ability to change ESP_MODEM_C_API_STR_MAX from Kconfig (IDFGH-13668) #649

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

embedcat
Copy link
Contributor

Description

This PR introduce ability to change ESP_MODEM_C_API_STR_MAX from Kconfig (idf.py menuconfig).

In esp_modem in C-API there is ESP_MODEM_C_API_STR_MAX which defines max size of AT response returned to user.
There is no obvious way to increase this size. Some workaround was found in #184, but I think use Kconfig option is more clear and straightforward.

Related

#184
#624


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title [modem]: Add ability to change ESP_MODEM_C_API_STR_MAX from Kconfig [modem]: Add ability to change ESP_MODEM_C_API_STR_MAX from Kconfig (IDFGH-13668) Sep 11, 2024
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this problem!
Agree that making this a config option is much cleaner then injecting via build system, LGTM!

@david-cermak david-cermak self-assigned this Sep 12, 2024
@david-cermak david-cermak merged commit 8e4d43e into espressif:master Sep 12, 2024
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants