[modem]: Add support for pausing netif #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
david-cermak
commented
Nov 21, 2024
•
david-cermak
commented
- allows to temporarily pause the network to supply AT commands
- allows to resume the network
- Closes Is there a way to send AT commands while keeping the connection, without using CMUX? (IDFGH-14106) #699
3 tasks
david-cermak
force-pushed
the
feat/modem_pause_network
branch
5 times, most recently
from
013507c to
ecc66a0
Compare
david-cermak
force-pushed
the
feat/modem_pause_network
branch
from
ecc66a0 to
c7c91bb
Compare
| /** | ||
| * @brief Resume the network interface | ||
| */ | ||
| void unpause(); |
There was a problem hiding this comment.
Resume is a better name.
euripedesrocha
approved these changes
Dec 5, 2024
also adds a demo of this feature to pppos client example
david-cermak
force-pushed
the
feat/modem_pause_network
branch
from
c2279f0 to
1db83cd
Compare
david-cermak
force-pushed
the
feat/modem_pause_network
branch
from
2cdb5d4 to
18f196f
Compare
david-cermak
force-pushed
the
feat/modem_pause_network
branch
11 times, most recently
from
6bea2b8 to
2603b33
Compare
* Use CONFIG_EXAMPLE_DETECT_MODE_BEFORE_CONNECT to demonstrate mode detect * Use disconnection flag to indicate conneciton issue and gracefully degrade to command mode * Remove IDF-verion < v5.0 code
david-cermak
force-pushed
the
feat/modem_pause_network
branch
from
2603b33 to
5e92990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.