Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): Move ESP_ZB_PACKED_STRUCT after union #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

P-R-O-C-H-Y
Copy link
Member

This PR fixes following compilation warnings:

note: attribute for 'union esp_zb_zcl_cluster_s::<unnamed>' must follow the 'union' keyword
warning: attribute ignored in declaration of 'union esp_zb_zcl_cluster_s::<unnamed>' [-Wattributes]

Changes tested using ESP-ZIGBEE-SDK in Arduino.

@chshu
Copy link
Collaborator

chshu commented Sep 29, 2024

It will be included in the next release, thanks.

@P-R-O-C-H-Y
Copy link
Member Author

P-R-O-C-H-Y commented Sep 30, 2024

Thanks! @chshu btw. is there any way to get some notification on new release?
Even in some internal MM channel or whatever.

@Hedda
Copy link
Contributor

Hedda commented Oct 8, 2024

Thanks! @chshu btw. is there any way to get some notification on new release?

@chshu Slightly off-topic but why are releases not also tagged and published here on GitHub as well?

https://github.com/espressif/esp-zigbee-sdk/releases

https://github.com/espressif/esp-zigbee-sdk/tags

There are several benefits to users if there are GitHub releases released here and version/revision tags:

https://docs.github.com/en/repositories/releasing-projects-on-github/about-releases

https://docs.github.com/en/repositories/releasing-projects-on-github/viewing-your-repositorys-releases-and-tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants