Skip to content

Conversation

brianignacio5
Copy link
Collaborator

Description

Add get security info detect chip to read IMAGE_CHIP_ID from devices before using magic number as fallback.

This should minimize maintenance of magic number for new chips.

Testing

Ideally you could try testing to connect a board which magic number is not defined in esptool-js magic2Chip function.

Another test is esp32 or esp32s2 will try to connect and run the get security info command, which will fail, and fallback to use the magic number to identify ROM class.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@brianignacio5 brianignacio5 self-assigned this Apr 22, 2025
Copy link

github-actions bot commented Apr 22, 2025

Download the artifacts for this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant