Skip to content

Commit

Permalink
revert: clear boot control register on ESP32-S3
Browse files Browse the repository at this point in the history
  • Loading branch information
@radimkarnis
radimkarnis committed Mar 19, 2024
1 parent 162238c commit 39cdec2
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions esptool/targets/esp32s3.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,6 @@ def hard_reset(self):
if uses_usb_otg:
self._check_if_can_reset()

# Clear force download boot mode to avoid the chip being stuck in download mode after reset
# workaround for issue: https://github.com/espressif/arduino-esp32/issues/6762
self.write_reg(
self.RTC_CNTL_OPTION1_REG, 0, self.RTC_CNTL_FORCE_DOWNLOAD_BOOT_MASK
)

print("Hard resetting via RTS pin...")
HardReset(self._port, uses_usb_otg)()

Expand Down

3 comments on commit 39cdec2

@Jason2866
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What regression happened, to revert this?

@dobairoland
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had issues with pytest-embedded integration. We needed to have a working tagged development release and didn't have time to solve the issue.

But the patch will be re-applied again and should make it to the final v4.8 release.

@xyzzy42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work to exit bootloader if it was entered via GPIO0 pull down. Only if it was done by setting RTC_CNTL_FORCE_DOWNLOAD_BOOT_MASK before a reset.
It also doesn't seem necessary when in USB OTG mode. It's only in USB Serial/JTAG mode that the bootloader reset will not clear this flag.

Please sign in to comment.