Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update metaplex decoding #919

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

fix: update metaplex decoding #919

wants to merge 23 commits into from

Conversation

justinenerio
Copy link
Contributor

@justinenerio justinenerio commented Apr 4, 2023

Changes

  • updates metadata decoding to use borsh

Related issues

Resolves PR #385
Fixes #881

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@justinenerio justinenerio marked this pull request as ready for review April 4, 2023 09:24
@justinenerio justinenerio requested a review from ookami-kb as a code owner April 4, 2023 09:24
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c74df4b) 81.13% compared to head (4d489c1) 81.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   81.13%   81.19%   +0.06%     
==========================================
  Files         183      188       +5     
  Lines        3939     3936       -3     
==========================================
  Hits         3196     3196              
+ Misses        743      740       -3     
Flag Coverage Δ
solana-beta 81.19% <100.00%> (?)
solana-stable 81.19% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@espresso-cash espresso-cash deleted a comment Sep 7, 2023
@espresso-cash espresso-cash deleted a comment Sep 7, 2023
@romeo4934 romeo4934 closed this Dec 28, 2023
@romeo4934 romeo4934 reopened this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching metaplex metadata for NFT
2 participants