Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZnDraw Visualizer patch #4984

Merged
merged 1 commit into from
Aug 23, 2024
Merged

ZnDraw Visualizer patch #4984

merged 1 commit into from
Aug 23, 2024

Conversation

phohenberger
Copy link
Contributor

@phohenberger phohenberger commented Aug 16, 2024 •
edited by jngrad
Loading

Partial fix for #4972

Description of changes:

  • Remove unnecessary socket-call in the update loop
  • Allow multiple instances of the visualizer in the same notebook
  • Have only one server run in the background when initializing the first Visualizer-instance
  • Center the camera on initialization
  • Clip wall shape at the box boundaries
  • Expose the self.zndraw-object for direct manipulation of ZnDraw
  • Bump to 'ZnDraw 0.4.6'

@phohenberger phohenberger marked this pull request as ready for review August 18, 2024 19:48
jngrad
jngrad approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@kodiakhq kodiakhq bot merged commit 3d5ca31 into espressomd:python Aug 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak Improvement Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phohenberger @jngrad