Feature/Html mailing #317

DutcherNL · 2023-04-26T14:01:43Z

Added ability to use HTML templates with emails

codecov · 2023-04-26T14:06:13Z

Codecov Report

Patch coverage: 79.66% and project coverage change: -0.61% ⚠️

Comparison is base (ed362f0) 95.84% compared to head (1eb8228) 95.23%.
Report is 69 commits behind head on master.

❗ Current head 1eb8228 differs from pull request most recent head bd23ac8. Consider uploading reports for the commit bd23ac8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   95.84%   95.23%   -0.61%     
==========================================
  Files         145      153       +8     
  Lines        6113     6342     +229     
  Branches      968      994      +26     
==========================================
+ Hits         5859     6040     +181     
- Misses        174      220      +46     
- Partials       80       82       +2

Flag	Coverage Δ
unittests	`95.23% <79.66%> (-0.61%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
core/urls.py	`100.00% <ø> (ø)`
squire/urls.py	`100.00% <ø> (ø)`
mailing/views.py	`36.76% <36.76%> (ø)`
mailing/sites.py	`90.00% <90.00%> (ø)`
mailing/mailing.py	`95.91% <95.91%> (ø)`
core/forms.py	`100.00% <100.00%> (ø)`
core/mailing.py	`100.00% <100.00%> (ø)`
mailing/forms.py	`100.00% <100.00%> (ø)`
mailing/loaders.py	`100.00% <100.00%> (ø)`
mailing/templatetags/mailing_tags.py	`100.00% <100.00%> (ø)`
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-04-26T14:54:06Z

mailing/forms.py

+
+class MailForm(forms.Form):
+    """A simple form to construct and send_to e-mails"""
+    to = forms.EmailField()


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

to = forms.EmailField()

to = forms.EmailField()

github-actions · 2023-04-26T14:54:06Z

mailing/forms.py

+            SimpleMessageEmail(
+                message=self.cleaned_data['text'],
+                subject=self.cleaned_data['subject']
+            ).send_to([self.cleaned_data['to']])


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

SimpleMessageEmail(

message=self.cleaned_data['text'],

subject=self.cleaned_data['subject']

).send_to([self.cleaned_data['to']])

SimpleMessageEmail(message=self.cleaned_data["text"], subject=self.cleaned_data["subject"]).send_to(

[self.cleaned_data["to"]]

)

If you want this on multiple lines, use a comma

github-actions · 2023-04-26T14:54:06Z

mailing/mailing.py

+    Renders and sends emails in a predefined template. It's basically the email alternative to the View class
+    :param template_name: The path and name of the template (without extention)
+    """
+    template_name: str = None


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

template_name: str = None

template_name: str = None

github-actions · 2023-04-26T14:54:06Z

mailing/mailing.py

+
+    def _get_mail_templates(self, extension: str):
+        """Gets the mail template with the given extention"""
+        return get_template(f"{self.template_name}.{extension}", using='EmailTemplates')


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

return get_template(f"{self.template_name}.{extension}", using='EmailTemplates')

return get_template(f"{self.template_name}.{extension}", using="EmailTemplates")

github-actions · 2023-04-26T14:54:06Z

mailing/tests/__init__.py

+
+__all__ = ["MailTestingMixin"]
+
+class MailTestingMixin(TestCase):


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

class MailTestingMixin(TestCase):

class MailTestingMixin(TestCase):

github-actions · 2023-04-26T14:54:10Z

squire/settings.py

+            ]
+        }
+    }


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

]

}

}

],

},

},

github-actions · 2023-04-26T14:54:10Z

squire/settings.py

+                )
+            ]
+        }
+    }
 ]

 WSGI_APPLICATION = 'squire.wsgi.application'


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

WSGI_APPLICATION = 'squire.wsgi.application'

WSGI_APPLICATION = "squire.wsgi.application"

github-actions · 2023-04-26T14:54:10Z

squire/settings.py

@@ -257,6 +274,9 @@
    os.path.join(BASE_DIR, 'core', 'static_compiled'),


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

os.path.join(BASE_DIR, 'core', 'static_compiled'),

os.path.join(BASE_DIR, "core", "static_compiled"),

github-actions · 2023-04-26T14:54:10Z

squire/settings.py

@@ -257,6 +274,9 @@
    os.path.join(BASE_DIR, 'core', 'static_compiled'),
 ]

+# Email settings
+EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'

EMAIL_BACKEND = "django.core.mail.backends.console.EmailBackend"

github-actions · 2023-04-26T14:54:11Z

squire/settings.py

@@ -257,6 +274,9 @@
    os.path.join(BASE_DIR, 'core', 'static_compiled'),
 ]

+# Email settings
+EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
+

 # The directory in which the coverage reports should be stored
 COVERAGE_REPORT_DIR = os.path.join(BASE_DIR, 'coverage')


[blackfmt] _{reported by reviewdog 🐶}

Suggested change

COVERAGE_REPORT_DIR = os.path.join(BASE_DIR, 'coverage')

COVERAGE_REPORT_DIR = os.path.join(BASE_DIR, "coverage")

Added missing code comments. Added global preferences for registration email footers. This should be refactored once #317 is merged.

DutcherNL added 2 commits April 18, 2023 18:07

Added html templated mails

34592e6

Wrote testcases for mailing module

76420a0

DutcherNL added emails Related to sending and receiving emails styling and layout Related to visual styling and layout (bootstrap, css, html) labels Apr 26, 2023

This comment was marked as off-topic.

Sign in to view

DutcherNL added 2 commits April 26, 2023 16:17

Processed feedback blacklinter

f232ebc

Allow mailing as bcc with SimpleMessageEmail

590ce0e

github-actions bot reviewed Apr 26, 2023

View reviewed changes

DutcherNL added 4 commits April 29, 2023 13:48

Added abs_url templatetag to load full urls in emails

a9c7140

Rewrote password reset to include html markup

3838e0b

Updated testcases and code linting

c25bb79

Change methods from private to public

1eb8228

This comment was marked as off-topic.

Sign in to view

Implemented CSS inliner and better mail template viewing

bd23ac8

EricTRL added a commit that referenced this pull request Sep 17, 2023

Email footer preferences + comments

3196a78

Added missing code comments. Added global preferences for registration email footers. This should be refactored once #317 is merged.

EricTRL mentioned this pull request Sep 22, 2023

Registration emails #334

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/Html mailing #317

Feature/Html mailing #317

DutcherNL commented Apr 26, 2023

This comment was marked as off-topic.

codecov bot commented Apr 26, 2023 •

edited

Loading

github-actions bot Apr 26, 2023

github-actions bot Apr 26, 2023

LenaWil May 9, 2023

github-actions bot Apr 26, 2023

github-actions bot Apr 26, 2023

github-actions bot Apr 26, 2023

github-actions bot Apr 26, 2023

github-actions bot Apr 26, 2023

github-actions bot Apr 26, 2023

github-actions bot Apr 26, 2023

github-actions bot Apr 26, 2023

This comment was marked as off-topic.

	return get_template(f"{self.template_name}.{extension}", using='EmailTemplates')
	return get_template(f"{self.template_name}.{extension}", using="EmailTemplates")


		__all__ = ["MailTestingMixin"]

		class MailTestingMixin(TestCase):

-            ]
-        }
-    }
+            ],
+        },
+    },

	WSGI_APPLICATION = 'squire.wsgi.application'
	WSGI_APPLICATION = "squire.wsgi.application"

		@@ -257,6 +274,9 @@
		os.path.join(BASE_DIR, 'core', 'static_compiled'),

	os.path.join(BASE_DIR, 'core', 'static_compiled'),
	os.path.join(BASE_DIR, "core", "static_compiled"),

	EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'
	EMAIL_BACKEND = "django.core.mail.backends.console.EmailBackend"

	COVERAGE_REPORT_DIR = os.path.join(BASE_DIR, 'coverage')
	COVERAGE_REPORT_DIR = os.path.join(BASE_DIR, "coverage")

Feature/Html mailing #317

Are you sure you want to change the base?

Feature/Html mailing #317

Conversation

DutcherNL commented Apr 26, 2023

This comment was marked as off-topic.

codecov bot commented Apr 26, 2023 • edited Loading

Codecov Report

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

LenaWil May 9, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

github-actions bot Apr 26, 2023

Choose a reason for hiding this comment

This comment was marked as off-topic.

codecov bot commented Apr 26, 2023 •

edited

Loading