Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Smart” (unicode) quotation marks with the committee nicknames of people #321

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

LenaWil
Copy link
Contributor

@LenaWil LenaWil commented Jul 6, 2023

This should make the quotation marks around the nick-names of committee members nicer looking.

I wrote this on my mobile phone during the downtime of an IW training and therefore haven’t actually tested it yet.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (19f7f25) 95.86% compared to head (48c80bb) 95.84%.
Report is 1 commits behind head on master.

❗ Current head 48c80bb differs from pull request most recent head 401f866. Consider uploading reports for the commit 401f866 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   95.86%   95.84%   -0.02%     
==========================================
  Files         161      145      -16     
  Lines        7106     6113     -993     
  Branches     1164      968     -196     
==========================================
- Hits         6812     5859     -953     
+ Misses        193      174      -19     
+ Partials      101       80      -21     
Flag Coverage Δ
unittests 95.84% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LenaWil LenaWil changed the title Update snippet_assoc_group.html “Smart” (unicode) quotation marks with the committee nicknames of people Jul 14, 2023
@LenaWil LenaWil marked this pull request as ready for review July 14, 2023 13:52
@EricTRL EricTRL merged commit 0568d3f into master Aug 23, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants