Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the comments from black off #335

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Turn the comments from black off #335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19d0106
turn comments off
LenaWil Sep 24, 2023
ce33fec
Rename linter
LenaWil Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions .github/workflows/black.yml → .github/workflows/linters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: Lint Black main
name: Linters

# Without review-dog… maybe it’s a bit of waste to make them run twice, but anyway.
on: [push, pull_request]

jobs:
lint-changed:
black-changed:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -20,20 +20,6 @@ jobs:
# formatting all the files, since filtering didn’t work, and then filtering them manually
# src: "${{ steps.changed-files.outputs.all_changed_files }}"
options: ""
- name: Comment the git pr
uses: reviewdog/action-suggester@v1
if: steps.changed-files.outputs.all_changed_files != ''
with:
tool_name: blackfmt
fail_on_error: false
continue-on-error: true
- name: format files again
uses: psf/black@stable
if: steps.changed-files.outputs.all_changed_files != ''
with:
# formatting all the files, since filtering didn’t work, and then filtering them manually
# src: "${{ steps.changed-files.outputs.all_changed_files }}"
options: ""
- name: (Files that are incorrectly formatted) ∩ (Files that have been changed in this commit or pull request)
run: git diff --exit-code -- ${{ steps.changed-files.outputs.all_changed_files }}
if: steps.changed-files.outputs.all_changed_files != ''