Issue508 performance tests #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n easier format to compare runs
…functionality, without a parameter/with the default of false, it keeps clusters between packets and adds to them if the first readout(s) in next packet belong there, or starts new clusters if time gap is large enough.
…a full flush occurs, otherwise builder keeps clusters in case future packets contain relevant readouts.
… in this branch as an experimental approach to clustering over packets - not needed in the end
JennyLouise
commented
May 3, 2022
| Hit hit; | ||
| hit.coordinate = 50; | ||
| hit.weight = 50; | ||
| hit.time = 50; |
JennyLouise
commented
May 3, 2022
| @@ -85,7 +85,7 @@ CSPECBase::CSPECBase(BaseSettings const &settings, | |||
| Stats.create("readouts.tof_neg", Counters.TimeStats.TofNegative); | |||
| Stats.create("readouts.prevtof_count", Counters.TimeStats.PrevTofCount); | |||
| Stats.create("readouts.prevtof_neg", Counters.TimeStats.PrevTofNegative); | |||
| Stats.create("readouts.tof_toolarge", Counters.TOFErrors); | |||
| Stats.create("readouts.tof_toolarge", Counters.TOFErrors); //move this to events.tof_toolarge | |||
There was a problem hiding this comment.
Or discard at readouts stage
JennyLouise
commented
May 3, 2022
test/performancetest.py
Outdated
| stats[stat_name] = metrics.return_metric(stat_name) | ||
| return(stats) | ||
|
|
||
| def efu_handles_data(efu, generator, module, throttle, packets_dropped): |
JennyLouise
commented
May 3, 2022
|
|
||
| from EFUMetrics import Metrics | ||
| import argparse | ||
| import csv |
There was a problem hiding this comment.
Move to EFUStat.py
mortenjc
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference / description
The branch you merge from should already reference an event-formation-unit github ticket number. You can add a descriptive title, but if an issue is referenced, you don't have to.
Checklist for submitter
Nominate for Group Code Review (Anyone can nominate it)
Indicate if you think the code should be reviewed in a Thursday code review session.
Also, nominate it on the code_review Slack channel.