Improved errutil package

essentialkaos · Jan 19, 2016 · c1c0a91 · c1c0a91
1 parent ef60fc0
commit c1c0a91
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/errutil/errutil.go b/errutil/errutil.go
@@ -28,7 +28,11 @@ func (e *Errors) Add(errs ...error) *Errors {
 		return e
 	}
 
-	e.errors = append(e.errors, errs...)
+	for _, err := range errs {
+		if err != nil {
+			e.errors = append(e.errors, err)
+		}
+	}
 
 	return e
 }

diff --git a/errutil/errutil_test.go b/errutil/errutil_test.go
@@ -29,6 +29,8 @@ var _ = Suite(&ErrSuite{})
 func (s *ErrSuite) TestPositive(c *C) {
 	errs := NewErrors()
 
+	errs.Add()
+	errs.Add(nil)
 	errs.Add(errors.New("1"))
 	errs.Add(errors.New("2"))
 	errs.Add(errors.New("3"))