Premade list of intervals for durations
#1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These were the connectors I found A lot of them did not have type='duration' so the ones I tested are: running: select c.image_name
FROM connectors c JOIN connector_tags ct ON c.id = ct.connector_id
where ct.endpoint_spec_schema::text like '%duration%' |
…dd-premade-list-of-time-formats
…dd-premade-list-of-time-formats
Removing blur on select as that is kind of aggressive ux
travjenkins
commented
Feb 26, 2025
There was a problem hiding this comment.
Something I noticed - so just calling out so it is not forgotten
travjenkins
commented
Feb 26, 2025
Comment on lines
70
to
83
| const inputRef = useRef<any | null>(null); | ||
| const position = useRef({ | ||
| beforeStart: 0, | ||
| beforeEnd: 0, | ||
| }); | ||
| useLayoutEffect(() => { | ||
| // Make sure the cursor stays where we want it | ||
| inputRef.current | ||
| ?.querySelector?.('input') | ||
| .setSelectionRange?.( | ||
| position.current.beforeStart, | ||
| position.current.beforeEnd | ||
| ); | ||
| }, [inputValue]); |
There was a problem hiding this comment.
Since we are uppercasing what is typed in we need to handle the cursor moving to the end of the string while typing lower case letters.
travjenkins
commented
Feb 26, 2025
| @@ -651,6 +654,8 @@ const generateUISchema = ( | |||
| addOption(controlObject, Options.format, Formats.date); | |||
| } else if (schemaHasFormat('time', jsonSchema)) { | |||
| addOption(controlObject, Options.format, Formats.time); | |||
| } else if (schemaHasFormat('duration', jsonSchema)) { | |||
| jsonSchema.pattern ??= ISO_8601_DURATION_PATTERN; | |||
There was a problem hiding this comment.
We need to toss on the pattern to get validation working
travjenkins
commented
Feb 26, 2025
There was a problem hiding this comment.
This has a fair amount of weirdness - but I won't call it out with GitHub comments as I worked as much detail into the code comments as I could.
travjenkins
changed the title
durations
kiahna-tucker
approved these changes
Feb 27, 2025
travjenkins
deleted the
travjenkins/feature/add-premade-list-of-time-formats
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#1467
Changes
1467
typeofdurationTests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots
Fills in default initially and after clicking clear button
Default value of something like
PT5Mwill match the option correctlyCan enter a full 8601 duration