Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running npm audit fix #1476

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Running npm audit fix #1476

merged 1 commit into from
Feb 26, 2025

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Feb 26, 2025 •
edited
Loading

Issues

npm audit

Changes

updated packages

Tests

ran npm start fine and app ran. Most of the upgraded packages would blow up at build time not run time.

@travjenkins travjenkins added dependencies Pull requests that update a dependency file change:unplanned Unplanned change, useful for things like doc updates labels Feb 26, 2025
kiahna-tucker
kiahna-tucker approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@kiahna-tucker kiahna-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without manual testing.

@travjenkins travjenkins marked this pull request as ready for review February 26, 2025 14:40
@travjenkins travjenkins requested a review from a team as a code owner February 26, 2025 14:40
@travjenkins travjenkins merged commit fc4dba0 into main Feb 26, 2025
3 checks passed
@travjenkins travjenkins deleted the travjenkins/deps/2024-02-26_audit branch February 26, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
change:unplanned Unplanned change, useful for things like doc updates dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker