Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating query so it will find when the full sourceCapture is being used #1487

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Updating query so it will find when the full sourceCapture is being used #1487

merged 2 commits into from
Mar 4, 2025

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Mar 4, 2025 •
edited
Loading

Issues

#1486

Changes

1486

  • Add another statement to fetch nested capture' settings in sourceCapture`

Tests

Manually tested

  • Used a sourceCapture that was set on the nested property
  • Used a sourceCapture that was just a string

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

If applicable - please include some screenshots of the new UI

@travjenkins travjenkins marked this pull request as ready for review March 4, 2025 00:43
@travjenkins travjenkins requested a review from a team as a code owner March 4, 2025 00:43
kiahna-tucker
kiahna-tucker approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@kiahna-tucker kiahna-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without manual testing.

@travjenkins travjenkins merged commit 7072460 into main Mar 4, 2025
3 checks passed
@travjenkins travjenkins deleted the travjenkins/bug/query-source-nester-capture-dataflow-reset branch March 4, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker