Convert the add icon button in the collection selector to a text button #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travjenkins
deleted the
kiahna-tucker/binding-selector/update-add-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are completely resolved by this PR:
#894
Changes
894
The following features are included in this PR:
Tests
Manually tested
Enter the materialization create workflow, click the Add button in the collection selector in the Output Collections section, and verify that the expected dialog opens, collections can be selected/deselected in the dialog, and the collection changes are reflected in the list of selected bindings.
Enter the materialization create workflow, update the form, click the Next CTA, and verify that the Add button in the collection selector in the Output Collections section is disabled while the form is active (i.e., an asynchronous task is in progress) and enabled once the form returns to an inactive state.
Enter the materialization edit workflow, click the Add button in the collection selector in the Output Collections section, and verify that the expected dialog opens, collections can be selected/deselected in the dialog, and the collection changes are reflected in the list of selected bindings.
Enter the materialization edit workflow, update the form, click the Next CTA, and verify that the Add button in the collection selector in the Output Collections section is disabled while the form is active (i.e., an asynchronous task is in progress) and enabled once the form returns to an inactive state.
Enter the derivation create workflow, click the Add button in the collection selector, and verify that the expected dialog opens, collections can be selected/deselected in the dialog, and the collection changes are reflected in the list of selected collections.
Automated tests
N/A
Screenshots
Materialization workflow
Derivation workflow