Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ops Logs: #933

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Ops Logs: #933

merged 3 commits into from
Jan 19, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Jan 19, 2024

Issues

#858

Changes

858

  • Building up a list of documents as more are loaded
  • Allow useJournalData to fetch based on docs OR bytes

Misc

  • Reordering the args passed to functions to make them more readable and useable

Tests

Manually tested

  • Ops logs and data preview

Automated tests

none yet

Screenshots

image

Better handling of refreshing so it does not fire multiple loads
Adding some debugging data in the view
Breaking up a big effect into smaller effects
Allowing to fetch chunks of data and not docs
Removing linear progress as the table will show loading
@travjenkins travjenkins marked this pull request as ready for review January 19, 2024 00:21
@travjenkins travjenkins requested a review from a team as a code owner January 19, 2024 00:21
@travjenkins travjenkins merged commit 5db4d94 into main Jan 19, 2024
3 checks passed
@travjenkins travjenkins deleted the travjenkins/opsLogs8 branch January 19, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant