Using update_only when doing background discover and content change
#955
Conversation
…ting collections and not adding NEW ones.
travjenkins
changed the title
update_only when doing background discover and content change
Setting update only if editing without changing endpoint
Passing data so we don't get weird issues with heights
…avjenkins/uxTweaks4
Storing off what rows are open
| const { generateCatalog, isSaving, formActive } = useDiscoverCapture( | ||
| entityType, | ||
| { | ||
| // We only want to set updateOnly if the user is editing and not updating the config |
There was a problem hiding this comment.
and not updating the config
Given the presence of the useResourceConfig_rediscoveryRequired hook above, it should be clear that the resource config is what is being referred to by the term config. However, it could not hurt to explicitly state that updateOnly should be set if the user (clicked the Next CTA and) did not change the resource config in an edit workflow.
| const { generateCatalog, isSaving, formActive } = useDiscoverCapture( | ||
| entityType, | ||
| { | ||
| // We only want to set updateOnly if the user is editing and not updating the config | ||
| // This should cover when a user has enable previously disabled collection(s) |
There was a problem hiding this comment.
a user has enable previously disabled collection(s)
Removing the passive voice from this comment will increase its clarity: This should cover when a user enables previously disabled collection(s).
| if (discoverResponse.error) { | ||
| // If we failed at discovery we need to clear draft ID like we do |
There was a problem hiding this comment.
This comment is a little muddled to me. What do you think of the following:
// If discovery fails, clear the draft ID to preserve the _Next_ CTA and allow the user to attempt to discover another time.| @@ -21,7 +21,7 @@ function MessageCell({ fields, message }: Props) { | |||
| </Typography> | |||
|
|
|||
| {fields ? ( | |||
| <Typography component="div" sx={BaseTypographySx}> | |||
| <Typography component="div" sx={{ ...BaseTypographySx }}> | |||
There was a problem hiding this comment.
The spread operator should not be needed here.
Issues
#953
#954
Changes
953
954
update_onlycolumn based on if we are rediscoveringupdate_onlywhen discoveringMisc
Tests
Manually tested
Automated tests
Screenshots
Edit content updated
Create Content not changed
Clicking the
refreshbutton still wants to do a discover so the user can get new items