Enable setting the backfill counter of all task bindings with a single action #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travjenkins
reviewed
Feb 7, 2024
travjenkins
reviewed
Feb 7, 2024
travjenkins
reviewed
Feb 7, 2024
travjenkins
reviewed
Feb 7, 2024
src/components/editor/Bindings/Backfill/useUpdateBackfillCounter.ts
Outdated
Show resolved
Hide resolved
travjenkins
reviewed
Feb 7, 2024
travjenkins
reviewed
Feb 7, 2024
| @@ -443,7 +446,7 @@ const getInitialState = ( | |||
| }, | |||
|
|
|||
| prefillBackfilledCollections: (liveBindings, draftedBindings) => { | |||
| const { addBackfilledCollection } = get(); | |||
| const { addBackfilledCollections } = get(); | |||
There was a problem hiding this comment.
Why are we having this stand alone function that loops through all the bindings?
We are already calling prefillResourceConfig right before calling this which means we loop through all the bindings twice in a row.
There was a problem hiding this comment.
Would you like to conflate the scope of prefillResourceConfig?
There was a problem hiding this comment.
Yeah - as best we can I would like that big initial looping to only be done once if possible.
travjenkins
reviewed
Feb 7, 2024
travjenkins
reviewed
Feb 7, 2024
src/components/editor/Bindings/Backfill/useUpdateBackfillCounter.ts
Outdated
Show resolved
Hide resolved
travjenkins
requested changes
Feb 7, 2024
travjenkins
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are completely resolved by this PR:
#962
The issues directly below are advanced by this PR:
#973
Changes
962
The following features are included in this PR:
Add a Backfill section directly above the bindings selector in edit workflows that contains a header, short description, and an outlined, toggle button with the label Backfill. This button should have the same styling as the binding-specific Backfill button.
Update the backfill counter of applicable, drafted bindings when the new backfill button is clicked. The toggle button state triggers are as follows:
Disabled: the button will be in a disabled state when an asynchronous task that updates the server is in progress and when the drafted specification does not contain at least one enabled binding.
Deselected: the button will be in a deselected state by default and when the backfill counter of any drafted binding has not been incremented in the editing session.
Selected: the button will be in a selected state when the backfill counter of all drafted bindings have been incremented in the editing session.
NOTE: The backfill counter of a drafted binding does not need to be reset if the binding is disabled post-incrementation in the editing session.
973
The following features are included in this PR:
OutlinedToggleButton.Tests
Manually tested
Automated tests
N/A
Screenshots
Capture edit | Bindings enabled | Backfill unset
Capture edit | Bindings enabled | Backfill set
Capture edit | Bindings disabled
Materialization edit | Bindings enabled | Backfill unset
Materialization edit | Bindings enabled | Backfill set
Materialization edit | Bindings disabled
Disabled primary colored outlined toggle button