Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling errors #971

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Handling errors #971

merged 2 commits into from
Feb 7, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Feb 6, 2024 •
edited
Loading

Issues

#887

Changes

887

  • Handle when the initial loading of data fails
  • Handle when fetching new data fails

Tests

Manually tested

  • Messed with network to get calls to fail

Automated tests

  • n/a

Screenshots

Handling when the initial fetch fails
image

When a fetch fails
image
image

Dark mode example
image

@travjenkins travjenkins marked this pull request as ready for review February 6, 2024 21:41
@travjenkins travjenkins requested a review from a team as a code owner February 6, 2024 21:41
@travjenkins travjenkins merged commit fae7ba9 into main Feb 7, 2024
3 checks passed
@travjenkins travjenkins deleted the travjenkins/opsLogs17 branch February 7, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker