Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct catalog name validation in details form store #974

Merged

Conversation

kiahna-tucker
Copy link
Member

@kiahna-tucker kiahna-tucker commented Feb 7, 2024

Issues

The issues directly below are completely resolved by this PR:
#963

Changes

963

The following features are included in this PR:

  • Display an error icon to the left of the Details form section header.

  • Display a page-level, error identifying the error in the details form section after the user clicks the Next CTA and this error should completely block downstream service calls.

Tests

Manually tested

  • scenarios you manually tested

Automated tests

N/A

Screenshots

Capture create | Before clicking the Next CTA with error

pr_screenshot-974-details_form_error-capture-pre_next

Capture create | After clicking the Next CTA with error

pr_screenshot-974-details_form_error-capture-post_next

Capture create | Tenant selected

pr_screenshot-974-details_form_error-capture-corrected

Capture create | Drafted specification updated

pr_screenshot-974-details_form_error-capture-succeeded

@kiahna-tucker kiahna-tucker marked this pull request as ready for review February 7, 2024 18:10
@kiahna-tucker kiahna-tucker requested a review from a team as a code owner February 7, 2024 18:10
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - have not manually tested yet

@travjenkins
Copy link
Member

tested a bit - looks good

@kiahna-tucker kiahna-tucker merged commit 00016be into main Feb 7, 2024
3 checks passed
@kiahna-tucker kiahna-tucker deleted the kiahna-tucker/bug-repair/prefixed-name-details-form branch February 7, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants