Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting the JSON themes to match #975

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Getting the JSON themes to match #975

merged 3 commits into from
Feb 7, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Feb 7, 2024 •
edited
Loading

Issues

#887

Changes

887

  • Set so the preview colors match the inspector colors match a bit better. This will work when the value is a string. If it is a number or something else the colors will not match.

Tests

Manually tested

  • viewed the logs

Automated tests

  • n/a

Screenshots

The two JSON views now match
image

@travjenkins travjenkins marked this pull request as ready for review February 7, 2024 17:45
@travjenkins travjenkins requested a review from a team as a code owner February 7, 2024 17:45
@travjenkins travjenkins merged commit d31457f into main Feb 7, 2024
1 check passed
@travjenkins travjenkins deleted the travjenkins/opsLogs18 branch February 7, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker