Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing ops logs for public release #983

Merged
merged 29 commits into from
Feb 20, 2024
Merged

Preparing ops logs for public release #983

merged 29 commits into from
Feb 20, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Feb 14, 2024 •
edited
Loading

Issues

#887

Changes

887

  • Passed the parsed bytes along with the docs so we know if we need to put the docs at the start or end
  • No longer mess with the offset if provided so loading newer logs would not sometimes load older logs

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • unit testing covered

Screenshots

If applicable - please include some screenshots of the new UI

@travjenkins
Adding back in setting a variable for where the logs should go
63695dd
@travjenkins
Starting to wire back up the AddingLogTypes
55c9855
@travjenkins
Cleaning up the store a bit as we no longer need to care what fetchin…
13cc20c 
…g is happening
@travjenkins
Some more cleaning up of state in store
c809709
@travjenkins
Starting to make the refresh call to be directly passing props to reduce
4928531 
  chance that states can start clashing when called in quick succession
@travjenkins
Passing around the start and end of parsing logs
d0f2695
@travjenkins
Getting the loading of new logs working
88198a9
@travjenkins
Prevent duplicate fetching
d08756f
@travjenkins
Cleaning up logging
7d2bed9
@travjenkins
No longer need the add type as we can just pass the parsed values
b866849
@travjenkins
Removing the add type
30b0862 
Starting to pass the offset when fetching newer logs
@travjenkins
Removing the add type
68eb879 
Starting to pass the offset when fetching newer logs
@travjenkins
Clean up logging
7685d6e 
Do not override the start if provided
Remove the adjusted bytes for now
@travjenkins
Do not think this applies anymore
606668e
@travjenkins
Passing the range with the docs
ddf1e3e
@travjenkins
Updating types a bit to plan for future typing
8dde995
@travjenkins
logging and comment cleanup
6c45eab
@travjenkins
Handling intervals
0c450e6
@travjenkins
Cleaning up the debounce
ca50a3f
@travjenkins
commenting
ff9c371
@travjenkins travjenkins marked this pull request as ready for review February 16, 2024 00:46
@travjenkins travjenkins requested a review from a team as a code owner February 16, 2024 00:46
@travjenkins travjenkins merged commit 41042f3 into main Feb 20, 2024
3 checks passed
@travjenkins travjenkins deleted the travjenkins/opsLogs_prepForRelease_1 branch February 20, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@travjenkins