-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Version field to the robustness model #19255
Add Version field to the robustness model #19255
Conversation
Hi @AwesomePatrol. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19255 +/- ##
=======================================
Coverage 68.75% 68.75%
=======================================
Files 420 420
Lines 35649 35675 +26
=======================================
+ Hits 24512 24530 +18
- Misses 9707 9711 +4
- Partials 1430 1434 +4 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just couple of nits
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AwesomePatrol, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4fcd7d0
to
d987aa2
Compare
It helps perform Txn before Compact in the same way as it is done in Kubernetes. Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
d987aa2
to
3dbe62f
Compare
/retest |
It helps perform Txn before Compact in the same way as it is done in Kubernetes.
/cc @serathius