Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Version field to the robustness model #19255

Merged

Conversation

AwesomePatrol
Copy link
Contributor

It helps perform Txn before Compact in the same way as it is done in Kubernetes.

/cc @serathius

@k8s-ci-robot
Copy link

Hi @AwesomePatrol. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (4e77d69) to head (3dbe62f).
Report is 37 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19255   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files         420      420           
  Lines       35649    35675   +26     
=======================================
+ Hits        24512    24530   +18     
- Misses       9707     9711    +4     
- Partials     1430     1434    +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e77d69...3dbe62f. Read the comment docs.

@serathius
Copy link
Member

/ok-to-test

Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just couple of nits

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AwesomePatrol AwesomePatrol force-pushed the add-version-to-robustness-model branch from 4fcd7d0 to d987aa2 Compare January 23, 2025 10:00
It helps perform Txn before Compact in the same way
as it is done in Kubernetes.

Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
@AwesomePatrol
Copy link
Contributor Author

/retest

@serathius serathius merged commit f98fa31 into etcd-io:main Jan 27, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants