Skip to content

Use static list of keys in model#21486

Open
serathius wants to merge 1 commit intoetcd-io:mainfrom
serathius:robustness-static
Open

Use static list of keys in model#21486
serathius wants to merge 1 commit intoetcd-io:mainfrom
serathius:robustness-static

Conversation

@serathius
Copy link
Member

@serathius serathius commented Mar 15, 2026

Continuation of #19973
PoC for #21133

Not huge change in benchmarks like before, need to check why

goos: linux
goarch: amd64
pkg: go.etcd.io/etcd/tests/v3/robustness/validate
cpu: AMD Ryzen 5 7600X 6-Core Processor             
                                                      │   old.txt    │              new.txt               │
                                                      │    sec/op    │   sec/op     vs base               │
ValidateLinearizableOperations/Successes-12             1081.4µ ± 0%   961.3µ ± 1%  -11.11% (p=0.002 n=6)
ValidateLinearizableOperations/AllFailures-12            311.5µ ± 2%   240.0µ ± 1%  -22.97% (p=0.002 n=6)
ValidateLinearizableOperations/PutFailuresWithRead-12    217.5µ ± 2%   209.8µ ± 5%   -3.53% (p=0.002 n=6)
geomean                                                  418.5µ        364.4µ       -12.91%

However for timing out antithesis linearization the speedup is huge from 67s to 24s

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@k8s-ci-robot
Copy link

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-robustness-amd64 128523f link true /test pull-etcd-robustness-amd64
pull-etcd-unit-test-386 128523f link true /test pull-etcd-unit-test-386
pull-etcd-unit-test-arm64 128523f link true /test pull-etcd-unit-test-arm64
pull-etcd-verify 128523f link true /test pull-etcd-verify
pull-etcd-robustness-arm64 128523f link true /test pull-etcd-robustness-arm64
pull-etcd-unit-test-amd64 128523f link true /test pull-etcd-unit-test-amd64
pull-etcd-coverage-report 128523f link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants