lease keep alive return lease not found error #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
lease-not-found
branch
from
6074e1d to
c2de4fc
Compare
davidli2010
requested changes
Dec 21, 2024
davidli2010
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently lease_keep_alive returns lease keeper and keep alive stream even when the lease id is not found or revoked, in such case
LeaseKeeper.keep_alivewill not return error and the keep alive stream will yield nothing, so we can't identify that the lease id is invalid.This patch changes
lease_keep_aliveto return an error when thelease_idargument passed hasttl <= 0(which means it's expired or revoked, in other wordsnot found).See also https://github.com/etcd-io/etcd/blob/b4450d510ddf0f011c874c28e95175b4bac7f6c8/client/v3/lease.go#L323-L325