Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Added checks on WMTS TestObjectType to replicate WMS functionality on StdTestObjectTypes.java #5

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

carlospzurita
Copy link

Fixes etf-validator/etf-webapp#195 . We added the same checks that are present on the WMS to replicate the functionality and let the user run the tests without adding parameters to the URL.

… StdTestObjectTypes.java

Signed-off-by: Carlos Palma <carlospalma@guadaltel.com>
@jonherrmann jonherrmann self-requested a review June 17, 2019 11:11
Copy link
Collaborator

@jonherrmann jonherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for a public (stable) service, so we can verify with the CI this is working and does not interfere with the other detection expressions

@carlospzurita
Copy link
Author

You can use these services to check the implementation of this bugfix

The API of the latest build of ETF from the next branch can be used to automatically test these service.

@jonherrmann
Copy link
Collaborator

We need white box tests on the unit test level to ensure this is working correctly and not affected by further changes. Please add the tests to the StdTestObjectTypeDetectorTest class.

…tdTestObjectTypeDetectorTest

	- Service tested:  http://www.ign.es/wmts/pnoa-ma

Signed-off-by: Carlos Palma <carlospalma@guadaltel.com>
@carlospzurita
Copy link
Author

On the last commit, tests for this functionality were added. Please let us know if this is what you were expecting, or if we need to improve them.

Signed-off-by: Carlos Palma <carlospalma@guadaltel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants