Skip to content

append EL version to metrics output directory name#258

Merged
jsign merged 1 commit intomasterfrom
jsign-add-el-version
Feb 6, 2026
Merged

append EL version to metrics output directory name#258
jsign merged 1 commit intomasterfrom
jsign-add-el-version

Conversation

@jsign
Copy link
Collaborator

@jsign jsign commented Feb 6, 2026

This PR adds automatic detection of the EL tag/sha of the ELs used by ere-guest/stateless-validator-{reth|ethrex}.

We had the version number for the zkVMs, but we didn't for ELs.

By doing this, we can add to the zkvm-metrics output which version of the EL was used.
Example of zkvm-metrics structure now:

zkevm-metrics
├── hardware.json
└── reth-v1.10.2
    └── zisk-v0.15.0
        ├── rpc_block_23326244.json
        ├── rpc_block_23326246.json
        ├── rpc_block_23326252.json
        ├── rpc_block_23326253.json
        └── rpc_block_23326259.json

@jsign jsign force-pushed the jsign-add-el-version branch from 18fe94b to 2d23b05 Compare February 6, 2026 17:47
@jsign
Copy link
Collaborator Author

jsign commented Feb 6, 2026

@han0110, I think we could consider doing the same build.rs idea in ere-guests.

Might be useful for zkboost or other users, and even potentially appending it to the release artifacts.

If that sounds good, here I could extract it via some pub constant in ere-guests or prob just only by parsing the release artifact names.

No need to do this urgently -- but might just be another thing that we could move to ere-guest if makes sense.

@jsign jsign marked this pull request as ready for review February 6, 2026 17:49
@jsign jsign merged commit 8907be9 into master Feb 6, 2026
1 check passed
@jsign jsign deleted the jsign-add-el-version branch February 6, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant