append EL version to metrics output directory name#258
Merged
Conversation
18fe94b to
2d23b05
Compare
Collaborator
Author
|
@han0110, I think we could consider doing the same Might be useful for If that sounds good, here I could extract it via some No need to do this urgently -- but might just be another thing that we could move to ere-guest if makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds automatic detection of the EL tag/sha of the ELs used by
ere-guest/stateless-validator-{reth|ethrex}.We had the version number for the zkVMs, but we didn't for ELs.
By doing this, we can add to the
zkvm-metricsoutput which version of the EL was used.Example of
zkvm-metricsstructure now: