add miniapp triangular multiplication #1029
Conversation
gulivarese
changed the title
gulivarese
force-pushed
the
guli/miniapp_triangular_multiplication
branch
from
aff92d6
to
4f16773
Compare
…file, refactor the call of the methods (solver-->multiplication)
gulivarese
force-pushed
the
guli/miniapp_triangular_multiplication
branch
from
4f16773
to
29b9dc5
Compare
| template <typename T> | ||
| linear_system_t<T> sampleLeftTr(blas::Uplo uplo, blas::Op op, blas::Diag diag, T alpha, SizeType m) { |
There was a problem hiding this comment.
Note to reviewers: This is code duplication, but it will disappear in favor of random matrices to be able to:
- re-enable tests
- allow complex types
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
|
cscs-ci run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1029 +/- ##
=======================================
Coverage 94.10% 94.10%
=======================================
Files 146 146
Lines 8843 8843
Branches 1121 1121
=======================================
Hits 8322 8322
Misses 326 326
Partials 195 195 ☔ View full report in Codecov by Sentry. |
| DLAF_MPI_CHECK_ERROR(MPI_Barrier(world)); | ||
| }; | ||
|
|
||
| const auto side = opts.side; |
There was a problem hiding this comment.
Do we need to assert the value of this parameter, given that we have sampleLeftTr?
There was a problem hiding this comment.
Yes, it is needed here and in the triangular solver miniapp as well. Currently the matrix a size is (m x m), so Side::Right fails unless m == n.
|
cscs-ci run |
|
cscs-ci run |
| const auto side = opts.side; | ||
| DLAF_ASSERT(side == blas::Side::Left, side); | ||
|
|
||
| const auto side = opts.side; |
There was a problem hiding this comment.
This redefines side (already defined above). See CI falure.
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
Fixes #763.