Print warning when MPI pool is unintentionally not used #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (and using more than one rank)
msimberg
force-pushed
the
test-init-warn-mpi-pool
branch
from
0c5f353
to
b44bab6
Compare
msimberg
changed the title
rasolca
approved these changes
Dec 12, 2023
|
cscs-ci run |
|
cscs-ci run |
RMeli
approved these changes
Jan 4, 2024
albestro
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165.
Warns if using more than one rank, no MPI pool, and
--dlaf:no-mpi-poolwas not used. This would indicate that the resource partitioner was not correctly initialized to use the MPI pool.Also fixes parsing of command line options in tests. When
pika_maintakesargcandargvit contains all the command line options that were not yet parsed by pika, including the added DLA-Future command line options. It's not really ideal that this is even possible, but I'm not sure yet how to deal with this better.