Add miniapps as tests #1112
Open
Add miniapps as tests #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run |
msimberg
force-pushed
the
miniapps-as-tests
branch
from
b395f89
to
9900e70
Compare
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
msimberg
force-pushed
the
miniapps-as-tests
branch
from
7619183
to
7a85649
Compare
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
msimberg
force-pushed
the
miniapps-as-tests
branch
2 times, most recently
from
7041343
to
ed29663
Compare
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
msimberg
force-pushed
the
miniapps-as-tests
branch
3 times, most recently
from
62b54e9
to
f7d52d6
Compare
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
msimberg
force-pushed
the
miniapps-as-tests
branch
2 times, most recently
from
8533a59
to
71eac9d
Compare
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
RMeli
reviewed
Apr 17, 2024
albestro
approved these changes
Apr 22, 2024
|
cscs-ci run |
RMeli
approved these changes
Apr 23, 2024
rasolca
reviewed
May 2, 2024
This reverts commit 0755556.
msimberg
force-pushed
the
miniapps-as-tests
branch
2 times, most recently
from
1ca0907
to
2094d9f
Compare
|
cscs-ci run |
…ete on CommunicatorGrid
msimberg
force-pushed
the
miniapps-as-tests
branch
from
2094d9f
to
eee19fd
Compare
|
cscs-ci run |
|
One more hang after the end of the hermitian multiplication test: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/7914784871. I've restarted the job. |
|
cscs-ci run |
msimberg
force-pushed
the
miniapps-as-tests
branch
from
02bf96a
to
9b71b31
Compare
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the algorithms miniapps as tests. Does not add
miniapp_lasetas it's not really testing anything too useful, and it messes with thecheck-threadssetup (which checks if OS threads are being spawned that shouldn't be spawned). The miniapps are run with 6 ranks,--grid-rows 3 --grid-cols 2, and otherwise default options.This splits
DLAF_addTestinto two separate functions: one which adds a test given a target (DLAF_addTargetTest) which is used to add the miniapps since they already have CMake targets, andDLAF_addTestwhich creates an executable and then callsDLAF_addTargetTest. The behaviour ofDLAF_addTestremains unchanged.This also adds a
CATEGORYparameter that can be added to tests as a label. This is added alongside theRANK_*labels. TheCATEGORYdefaults toUNITfor "unit tests", and I set it toMINIAPPfor the miniapps. I'm fine with making the choice explicit and/or renaming/adding the categories. I then use theRANKandCATEGORYlabels to generate jobs the same wayRANKis used currently onmaster. Combinations that have no tests are not added as CI jobs.Finally, many miniapps were hanging on the CUDA configurations, where they run with only one worker thread and one MPI thread. I've changed the
waitLocalTilescalls topika::waitcalls beforeMPI_Barrieris called to make sure that really nothing is running anymore and deadlocks are avoided. I've only changed them topika::waitafter the algorithms are called, but for consistency it might make sense to usepika::waitanywhere beforeMPI_Barrieris called?