Add missing includes with the help of inshpect #1129
Conversation
|
cscs-ci run |
gulivarese
force-pushed
the
inshpectGulivarese
branch
from
51a2abd
to
d804bbc
Compare
|
Reminder, we should make the inshpect check required before merging this. |
msimberg
changed the title
Certainly not... It should take a couple of minutes at most. I can't seem to cancel the runs either (and |
Apparently something is wrong with actions... even #1146 is having problems. |
.github/workflows/inshpect.yml
Outdated
|
|
||
| jobs: | ||
| inshpect: | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Would be nice to run it already on ubuntu 24.04
There was a problem hiding this comment.
Perfect, I add this review!
Thanks @rasolca !
There was a problem hiding this comment.
That's a very good point @rasolca. @gulivarese this means that you can now install dasel and ripgrep directly with apt. dasel was not yet available in 22.04, and ripgrep was not compiled with PCRE2 in 22.04, so they both had to be installed manually with 22.04. With 24.04 both of these are fixed.
There was a problem hiding this comment.
@msimberg so now I need to runs-on: ubuntu-22.04 and then I can delete the two steps below about the installation of the two dependencies (ripgrep and dasel).
Is it correct?
There was a problem hiding this comment.
You need runs-on: ubuntu-24.04 (note 24, not 22). You of course need to install them with apt instead and since I haven't tried it myself the ubuntu versions may not be compatible, but give it a try and then we'll see if it works.
There was a problem hiding this comment.
Yes, sorry I made an mistake when I wrote 22.04
I pushed my modify and my updates.
…ation of this two dependencies
|
cscs-ci run |
No description provided.