-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom coalescing heuristic and introduce a number of new configuration options for memory pools #1183
Merged
rasolca
merged 9 commits into
eth-cscs:master
from
msimberg:umpire-pool-heuristics-alignment
Oct 25, 2024
Merged
Use custom coalescing heuristic and introduce a number of new configuration options for memory pools #1183
rasolca
merged 9 commits into
eth-cscs:master
from
msimberg:umpire-pool-heuristics-alignment
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscs-ci run |
1 similar comment
cscs-ci run |
RMeli
reviewed
Sep 10, 2024
msimberg
commented
Sep 11, 2024
msimberg
force-pushed
the
umpire-pool-heuristics-alignment
branch
from
September 17, 2024 07:56
dd78a8f
to
b099056
Compare
cscs-ci run |
cscs-ci run |
cscs-ci run |
rasolca
approved these changes
Oct 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
…nfiguration options for memory pools (#1183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to replace #1143 as a more permanent solution.
This introduces:
I'm 100% sure I haven't chosen the best names for the new options, but I'd like to discuss them with you first before making any further changes. Additionally, I'm 100% aware that the coalescing options add complexity. My intention with them is primarily to have as debugging options, not necessarily something most users would change. The default behaviour is very "vanilla", but in case we see situations where too much memory is used or similar we can use these options to try to tune how umpire frees/coalesces blocks in the pool.
As a semi-related change I've also namespaced the Umpire pools with a
DLAF_
prefix since we used quite generic names. I suppose we'd notice if the names clash, but I'd rather be on the safe side and avoid clashes (e.g. if the non-thread safe pool is accessed without synchronization I expect bad things to happen).