Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stdexec compilation to c++ files + add CI for cuda stdexec configuration #1188

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

aurianer
Copy link
Collaborator

@aurianer aurianer commented Sep 16, 2024

@aurianer aurianer self-assigned this Sep 16, 2024
@aurianer aurianer force-pushed the nvcc_stdexec branch 3 times, most recently from 69a4d67 to b32c9e4 Compare September 17, 2024 15:13
@aurianer
Copy link
Collaborator Author

cscs-ci run

@aurianer
Copy link
Collaborator Author

I opened #1189 to reenable testing once CI is on alps

@aurianer
Copy link
Collaborator Author

cscs-ci run

@aurianer
Copy link
Collaborator Author

cscs-ci run

@aurianer
Copy link
Collaborator Author

cscs-ci run

@aurianer aurianer marked this pull request as ready for review September 18, 2024 06:10
@msimberg
Copy link
Collaborator

Four(!) hangs on the hermitian matrix multiplication test in different configurations this time. I suppose it's time to try to reproduce it again. Clearly something is still badly wrong there. (Two of the hangs were after the test itself has passed, two in the middle of the test.)

Unrelated to the changes here obviously...

Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. This looks good to me otherwise. Thanks @aurianer!

include/dlaf/permutations/general/impl.h Outdated Show resolved Hide resolved
ci/.gitlab-ci.yml Outdated Show resolved Hide resolved
include/dlaf/permutations/general/impl.h Show resolved Hide resolved
@aurianer
Copy link
Collaborator Author

cscs-ci run

@aurianer
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg requested a review from RMeli September 18, 2024 14:10
@msimberg
Copy link
Collaborator

Only thing that came to mind now is that with this change there are three GCC 13 CI configurations. Do we want to prune some away or keep them all?

@rasolca rasolca merged commit 1c44130 into eth-cscs:master Sep 20, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants