Patch addAlpha definitions to work around buggy HIP complex operator overloads #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run |
aurianer
approved these changes
Sep 26, 2024
msimberg
force-pushed
the
hip-complex-operators-workaround
branch
from
0ece43f
to
52f7ee2
Compare
|
cscs-ci run |
RMeli
approved these changes
Sep 27, 2024
rasolca
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1083 (at least "temporarily"). This simply takes the patch we already use in upstream spack and proposes to make it semi-permanent, until we some day decide to revisit #1083. This came up again when compiling DLA-Future without patches on LUMI with HIP 6 (also without patches, unlike the spack-installed HIP 6).