Small changes in the plotting scripts #1203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aurianer
commented
Oct 18, 2024
aurianer
commented
- Adds complex and double in the caption
- Limit the caption to use the base directory name and not the absolute path (otherwise the caption of the plot was unreadable)
aurianer
force-pushed
the
small_changes_in_plotting_scripts
branch
from
57bff0b
to
75ff036
Compare
msimberg
reviewed
Oct 22, 2024
albestro
reviewed
Oct 28, 2024
aurianer
force-pushed
the
small_changes_in_plotting_scripts
branch
from
75ff036
to
d56b4bc
Compare
|
I rebased, the change with the label is in the last commit |
msimberg
approved these changes
Nov 1, 2024
| @@ -352,14 +352,29 @@ def parse_jobs(data_dirs, distinguish_dir=False): | |||
| if not isinstance(data_dirs, list): | |||
| data_dirs = [data_dirs] | |||
| data = [] | |||
| for data_dir in data_dirs: | |||
| for data_dir_label in data_dirs: | |||
| dir_label = data_dir_label.split(":") | |||
There was a problem hiding this comment.
I don't know what the most appropriate error checking/reporting thing is for python, but could we at least say assert(1 <= len(dir_label) <= 2) or whatever the python way of doing that is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.