Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap communicators in RoundRobin and Pipeline in CommunicatorGrid #993

Merged
merged 148 commits into from
Dec 12, 2023
Merged

Wrap communicators in RoundRobin and Pipeline in CommunicatorGrid #993

merged 148 commits into from
Dec 12, 2023

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Sep 26, 2023 •
edited
Loading

Nothing to see here yet. Only opening for CI at this point. Better description to follow.

To do:

msimberg and others added 19 commits September 20, 2023 13:55
@msimberg
TEMP: First hacky version of round-robin pipelined communicator grid
23edf4f
@msimberg
Add configuration option for number of communicators per pipeline in …
ccff64c 
…CommunicatorGrid
@msimberg
Add POC support for share pipeline access from CommunicatorGrid
9908c47
@msimberg
Add workaround for TuneParameters getting pika thread pools
83209fe
@msimberg
Remove TODO about removing wait in reduction to band
d32419b
@msimberg
Rename communicator grid num pipelines/communicators tune parameter
e615b2a
@msimberg
Add with_result_of utility
e152b39
@msimberg
Add TODO for naming Pipeline::read
f9374df
@msimberg
Remove default constructor for Pipeline again
58736d2
@msimberg
Clean up sub pipeline implementation
80eb161
@msimberg
Rename CommunicatorGrid::numCommunicators to numPipelines
ebe70ca
@msimberg
Rename *_pipeline_ members to *_pipelines_ in CommunicatorGrid
eb436cf
@msimberg
Add TODO for communicator use in tridiagonal eigensolver merge
1618b50
@msimberg
Remove comm from wrapper variable names in Pipeline
b61a150
@msimberg
Use snake_case and CamelCase consistently in new functionality
b20981d
@msimberg
Assert that bt_band_to_tridiag has at least two communicator grid pip…
0e37877 
…elines
@msimberg
Rename mpi_chain_col_shared to mpi_chain_col_p2p in bt_band_to_tridiag
e94825c
@msimberg
Pass CommunicatorGrid by reference
d9db5f8
@msimberg
Add documentation for Pipeline::sub_pipeline
91d03cd
@msimberg msimberg added this to the API refactoring milestone Sep 26, 2023
@msimberg msimberg self-assigned this Sep 26, 2023
@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Dec 12, 2023 •
edited
Loading

alby/trisolver-dist-opt-step3 is now merged into this PR. #997 and #998 are ahead in the queue to be merged. However, it will need at least one more conflict resolution.

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

cscs-ci run

@msimberg
Copy link
Collaborator Author

cscs-ci run

@rasolca rasolca merged commit 414374d into eth-cscs:master Dec 12, 2023
4 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2023
@rasolca
Doc: Wrap communicators in RoundRobin and Pipeline in `Communicat…
b72724d 
…orGrid` (#993)
@msimberg msimberg mentioned this pull request Dec 14, 2023
Closed
@albestro albestro mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasolca rasolca rasolca approved these changes

@albestro albestro albestro approved these changes

Assignees

@msimberg msimberg

Labels
None yet
Projects
DLA-F Planning
Archived in project
Milestone
API refactoring
Development

Successfully merging this pull request may close these issues.

Management of tags for MPI_Isend and MPI_Irecv across and within algorithms
3 participants
@msimberg @albestro @rasolca