Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slurm 22.05.6 #4

Merged
merged 1 commit into from
Oct 5, 2023
Merged

add slurm 22.05.6 #4

merged 1 commit into from
Oct 5, 2023

Conversation

simonpintarelli
Copy link
Member

@simonpintarelli simonpintarelli commented Sep 21, 2023

copy directory from 22.05.5 and add an entry in version matrix in github workflows.

Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Simon.

For the future: the slurm version 22.05.6 only appears inside one of the new files in one location - it might be possible to template this so that we don't need a new directory for each version of SLURM that we support.

@jpcoles
Copy link

jpcoles commented Sep 21, 2023

Looks good to me! Thanks Simon.

For the future: the slurm version 22.05.6 only appears inside one of the new files in one location - it might be possible to template this so that we don't need a new directory for each version of SLURM that we support.

Hi Ben,

I made the design decision to keep separate directories to explicitly avoid trying to template anything. I wanted to keep it stupidly simple where each version was guaranteed to continue working. Slurm tends to introduce or deprecate features and having each version completely independent means we don't have to worry about maintaining backward compatibility or have rules to account for these changes. Furthermore, it's not much work to copy a few files even if they do end up being the same. This is now the first time in a year that we've had to add another version. From the user's perspective all they need to do is say with version of slurm they want.

@jpcoles jpcoles merged commit e2e977b into main Oct 5, 2023
5 checks passed
@simonpintarelli simonpintarelli deleted the slurm-22.05.6 branch December 17, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants