Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging with spdlog #3

Merged
merged 19 commits into from
Aug 14, 2024
Merged

Add logging with spdlog #3

merged 19 commits into from
Aug 14, 2024

Conversation

msimberg
Copy link
Collaborator

Based on #2 for CI.

Currently only converts some fmt::print calls to spdlog. Redirects all messages to syslog, and warnings or worse to stdout.

Please comment on desired logging levels, formatting options etc.

A functional change that is required before this is ready is to initialize the default logger independently of the cli entry point. It should be possible to set the verbosity from the cli tool I guess, but for library-only use it'd be nice if the loggers were set up without requiring an explicit call to initialize the loggers.

src/cli/start.cpp Outdated Show resolved Hide resolved
src/cli/uenv.cpp Outdated Show resolved Hide resolved
src/uenv/log.cpp Outdated Show resolved Hide resolved
src/uenv/log.cpp Outdated Show resolved Hide resolved
@msimberg msimberg requested a review from bcumming July 26, 2024 11:20
@msimberg msimberg marked this pull request as ready for review July 26, 2024 11:20
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - just a couple of little nits.

meson.build Show resolved Hide resolved
src/cli/uenv.h Outdated Show resolved Hide resolved
src/uenv/log.h Show resolved Hide resolved
@bcumming bcumming merged commit 42c3502 into eth-cscs:main Aug 14, 2024
3 checks passed
@msimberg msimberg deleted the spdlog branch August 14, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants