-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging with spdlog #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimberg
commented
Jul 25, 2024
msimberg
commented
Jul 25, 2024
msimberg
commented
Jul 25, 2024
msimberg
commented
Jul 25, 2024
msimberg
commented
Jul 25, 2024
…through all messages to subloggers
msimberg
commented
Jul 26, 2024
msimberg
commented
Jul 26, 2024
bcumming
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - just a couple of little nits.
bcumming
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2 for CI.
Currently only converts some
fmt::print
calls to spdlog. Redirects all messages to syslog, and warnings or worse to stdout.Please comment on desired logging levels, formatting options etc.
A functional change that is required before this is ready is to initialize the default logger independently of the cli entry point. It should be possible to set the verbosity from the cli tool I guess, but for library-only use it'd be nice if the loggers were set up without requiring an explicit call to initialize the loggers.