feat: added Font Fetching and Extraction from target website#4
Open
Proxyy587 wants to merge 3 commits intoethanjyx:mainfrom
Open
feat: added Font Fetching and Extraction from target website#4Proxyy587 wants to merge 3 commits intoethanjyx:mainfrom
Proxyy587 wants to merge 3 commits intoethanjyx:mainfrom
Conversation
Owner
|
thanks for adding this, the screenshot shows a few cards showing different fonts, I can imagine if the list is larger it will take more vertical space, hence I'm a bit unsure about this. We may need a better way to display all the results. |
The whole list is not displayed at once. Initially, only the top 3 fonts are shown, and the remaining fonts are revealed when the user clicks on "Show more". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Font extraction:
Detects fonts from stylesheets, inline @font-face, and font-family in CSS
Resolves font file URLs against the stylesheet URL for correct paths
Font UI :
Preview line in the actual font
"Available on" badge (Google Fonts / Fontshare)
Download font button linking to the source URL or Google Fonts
Changed
API & types: BrandExtractionResult includes fonts: FontAsset[]. FontAsset is { family: string; url?: string; sourceUrl?: string }.
Empty extraction now requires at least one of: logos, colors, backdrops, or fonts.
Scraper logic preserves the font entry with sourceUrl when priorities are equal.
Preview
Thanks to @CyberWasDreaming0 for helping with the font fetching feature.