Draft of the L2 transaction fee specification #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Readme.md - Updated glossary with new terms - Added Abstract and 1.1 Overview - Added Section 2 with subsections - Section 3: Started adding requirements and testablity statements
- completed section 3.1 - sections 3.2 and 3.3 are still to do
ZxSix666
approved these changes
Apr 3, 2023
Therecanbeonlyone1969
changed the title
0x000hx
reviewed
Apr 6, 2023
workitems/l2-transaction-fees/l2-transaction-fees-v1.0-psd01.md
Outdated
Show resolved
Hide resolved
|
G |
ZxSix666
approved these changes
Apr 6, 2023
- Added immutable link tags for sections - updated R10 based on feedback
|
A |
Closed
- fixing wording in testability for R1 - fixed layout of test steps in testability for R14
Closed
t0mcr8se
approved these changes
Sep 28, 2023
|
I've completed my review of the L2 Transaction Fee spec. No comments from me — I support its approval. |
DZGoldman
reviewed
Oct 18, 2023
workitems/l2-transaction-fees/l2-transaction-fees-v1.0-psd01.md
Outdated
Show resolved
Hide resolved
workitems/l2-transaction-fees/l2-transaction-fees-v1.0-psd01.md
Outdated
Show resolved
Hide resolved
workitems/l2-transaction-fees/l2-transaction-fees-v1.0-psd01.md
Outdated
Show resolved
Hide resolved
Updated the following definitions: - Execution Fee - Priority Fee - Sequencer
|
Please, rer-eview after feedback updates. |
DZGoldman
approved these changes
Nov 1, 2023
|
@lgingerich @t0mcr8se @smartcontracts please reapprove the PR! |
|
I'm good with the recent updates. |
smartcontracts
approved these changes
Nov 29, 2023
- Removed Base Fee definition and updated spec accordingly - Reworded Execution Fee definition and updated spec accordingly - Added Data Fee definition and updated spec accordingly - Added 6 new requirements on L1 and L2 gas price, gas cost and calculation transparency and verification including testability statement. - Updated requirements numbers.
|
@smartcontracts @lgingerich @DZGoldman @t0mcr8se @0x000hx ... updated spec as discussed during our last WG meeting. Please, review and if ok, please approve. Thank you! |
|
I approve the latest changes |
|
Seems good to me |
Therecanbeonlyone1969
changed the title
|
lgtm |
smartcontracts
approved these changes
Jan 23, 2024
|
We have enough approvals (4) to merge the PR and then submit it to the next PGB meeting as a draft release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the initial set of commits to this PR: