-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fixes #760
Build fixes #760
Conversation
@ognjenkurtic Can you please elaborate on why we can't use hardhat-ethers? The bug I faced was because the |
This plugin adds an ethers object to the Hardhat Runtime Environment (HRE). You can read more about HRE here. It is basically a development environment and the hardhat-ethers plugin just makes it easier to use ethers.js in hardhat tasks, scripts and tests. When your application needs to talk to the blokchain in production, you should directly rely on ethers.js or similar libs as hardhat is not supposed to be present in production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a Prisma warning to upgrade to 5.5.2. Otherwise Looks good and starts correctly for me.
Understood. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add an issue for implementing etherjs functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Build was broken because of incorrect usage of hardhat ethers in application source. Hardhat ethers is intended to be used only inside hardhat scripts, tests and tasks. For app purposes, we should use ethers.js
Related Issue
n\a
Motivation and Context
Fixes the build
How Has This Been Tested
local build, start, test and test:e2e
Screenshots (if appropriate)
Types of changes
Checklist