Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log SuperchainWETH events #142

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Conversation

tremarkley
Copy link
Contributor

@tremarkley tremarkley commented Sep 12, 2024

Part of #135

Logs SuperchainWETH SendERC20 and RelayERC20 events. This is the same thing we do for L2NativeSuperchainERC20. Additionally, adds gas padding to auto relay ExecuteMessage transactions, more context on why gas padding is needed in this issue: #143

Copy link

cloudflare-workers-and-pages bot commented Sep 12, 2024

Deploying supersim with  Cloudflare Pages  Cloudflare Pages

Latest commit: 41f74bd
Status: ✅  Deploy successful!
Preview URL: https://974c6e65.supersim.pages.dev
Branch Preview URL: https://harry-superchainweth-logging.supersim.pages.dev

View logs

@tremarkley
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tremarkley and the rest of your teammates on Graphite Graphite

@tremarkley tremarkley force-pushed the harry/superchainweth_logging branch 3 times, most recently from 0b67b2e to b744a2b Compare September 12, 2024 23:50
@tremarkley tremarkley marked this pull request as ready for review September 12, 2024 23:50
@tremarkley tremarkley requested a review from a team as a code owner September 12, 2024 23:50
Copy link
Contributor

@jakim929 jakim929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

maybe later it might prob make sense to refactor the logger to be reusable for all SuperchainERC20 into a single function since there will be more token types as well. #144

@tremarkley tremarkley merged commit 2731cfc into main Sep 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants