Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply SuperchainWETH contracts to forked networks #148

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

tremarkley
Copy link
Contributor

@tremarkley tremarkley commented Sep 16, 2024

Part of #135

  • Adds SuperchainWETH contracts to the interop applier package
  • Enables loading env variables from .env
  • Updates tests to use rpc urls from repo secrets
    • This was needed because the public rpc urls were causing test failures

Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2024

Deploying supersim with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7ffbb5
Status: ✅  Deploy successful!
Preview URL: https://38d402b3.supersim.pages.dev
Branch Preview URL: https://harry-etch-weth-contracts.supersim.pages.dev

View logs

@tremarkley
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tremarkley and the rest of your teammates on Graphite Graphite

@tremarkley tremarkley marked this pull request as ready for review September 16, 2024 18:41
@tremarkley tremarkley requested a review from a team as a code owner September 16, 2024 18:41
interop/applier.go Outdated Show resolved Hide resolved
@tremarkley tremarkley force-pushed the harry/etch_weth_contracts branch 2 times, most recently from 0c0b75d to 65102f1 Compare September 16, 2024 22:02
@@ -59,7 +66,7 @@ func main() {
},
}

ctx := opio.WithInterruptBlocker(context.Background())
ctx := ctxinterrupt.WithSignalWaiterMain(context.Background())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to be updated based on refactor done in ethereum-optimism/optimism#11511

@tremarkley tremarkley force-pushed the harry/etch_weth_contracts branch 6 times, most recently from 002fc24 to 2d609c2 Compare September 16, 2024 22:51
Copy link
Contributor

@jakim929 jakim929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! one nit

interop/applier.go Outdated Show resolved Hide resolved
@tremarkley tremarkley merged commit a9c8c63 into main Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants