Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: clean up code for CrossChainPingPong and add walkthrough #149

Merged
merged 1 commit into from
Sep 17, 2024
Merged

example: clean up code for CrossChainPingPong and add walkthrough #149

merged 1 commit into from
Sep 17, 2024
+3,047 −59

Conversation

jakim929
Copy link
Contributor

@jakim929 jakim929 commented Sep 17, 2024 •
edited
Loading

  • accidentally merged the last PR without these fixes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 17, 2024 •
edited
Loading

Deploying supersim with  Cloudflare Pages  Cloudflare Pages

Latest commit: a2ad02a
Status: ✅  Deploy successful!
Preview URL: https://70f40aeb.supersim.pages.dev
Branch Preview URL: https://09-17-example-clean-up-code.supersim.pages.dev

View logs

@jakim929
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jakim929 and the rest of your teammates on Graphite Graphite

@jakim929 jakim929 force-pushed the 09-17-example_clean_up_code_for_crosschainpingpong_and_add_walkthrough branch from 57868a3 to c681120 Compare September 17, 2024 15:15
@jakim929 jakim929 marked this pull request as ready for review September 17, 2024 15:19
@jakim929 jakim929 requested a review from a team as a code owner September 17, 2024 15:19
@jakim929 jakim929 force-pushed the 09-17-example_clean_up_code_for_crosschainpingpong_and_add_walkthrough branch from c681120 to fcda6da Compare September 17, 2024 17:16
tremarkley
tremarkley approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@tremarkley tremarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, really good comments documenting the contract

@jakim929 jakim929 force-pushed the 09-17-example_clean_up_code_for_crosschainpingpong_and_add_walkthrough branch from fcda6da to f34bd15 Compare September 17, 2024 21:52
@jakim929 jakim929 force-pushed the 09-17-example_clean_up_code_for_crosschainpingpong_and_add_walkthrough branch from f34bd15 to a2ad02a Compare September 17, 2024 21:55
@jakim929 jakim929 merged commit daa397a into main Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremarkley tremarkley tremarkley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakim929 @tremarkley