Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove temp file on shutdown, allow specifying log dir #165

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jakim929
Copy link
Contributor

@jakim929 jakim929 commented Sep 19, 2024

closes #132

  • deletes temp files for
    • logs
    • genesis.json: the genesis.json files can get very large and fill up disk space
  • --logs.directory allows specifying log directory - if specified it won't be deleted by default

Copy link

cloudflare-workers-and-pages bot commented Sep 19, 2024

Deploying supersim with  Cloudflare Pages  Cloudflare Pages

Latest commit: 087a64f
Status: ✅  Deploy successful!
Preview URL: https://5f6f5cf6.supersim.pages.dev
Branch Preview URL: https://09-19-fix-remove-temp-file-o.supersim.pages.dev

View logs

@jakim929
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jakim929 and the rest of your teammates on Graphite Graphite

@jakim929 jakim929 marked this pull request as ready for review September 19, 2024 18:11
@jakim929 jakim929 requested a review from a team as a code owner September 19, 2024 18:11
Copy link
Contributor

@tremarkley tremarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my macbook storage thanks you

@jakim929 jakim929 force-pushed the 09-19-fix_remove_temp_file_on_shutdown branch from 8c2f4b1 to b7b8a70 Compare September 19, 2024 19:35
@jakim929 jakim929 force-pushed the 09-19-fix_remove_temp_file_on_shutdown branch from b7b8a70 to 087a64f Compare September 19, 2024 19:41
@jakim929 jakim929 changed the title fix: remove temp file on shutdown fix: remove temp file on shutdown, allow specifying log dir Sep 19, 2024
@jakim929 jakim929 merged commit 405b650 into main Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete logs by default
2 participants