-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: print available accounts on startup #39
Merged
Merged
+279
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jakim929
commented
Jul 10, 2024
jakim929
force-pushed
the
07-09-feat_print_available_accounts_on_startup
branch
3 times, most recently
from
July 10, 2024 15:20
5fc3004
to
07e5977
Compare
jakim929
force-pushed
the
07-09-feat_print_available_accounts_on_startup
branch
from
July 10, 2024 15:22
07e5977
to
c8845ae
Compare
jakim929
force-pushed
the
07-09-feat_print_available_accounts_on_startup
branch
from
July 10, 2024 16:42
c8845ae
to
63b1b7b
Compare
tremarkley
reviewed
Jul 11, 2024
jakim929
force-pushed
the
07-09-feat_print_available_accounts_on_startup
branch
from
July 11, 2024 00:52
63b1b7b
to
8563981
Compare
hamdiallam
approved these changes
Jul 11, 2024
hamdiallam
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left 1 suggestion to try simplify config
jakim929
force-pushed
the
07-09-feat_print_available_accounts_on_startup
branch
from
July 11, 2024 15:39
8563981
to
d2d50f9
Compare
tremarkley
approved these changes
Jul 11, 2024
jakim929
force-pushed
the
07-09-feat_print_available_accounts_on_startup
branch
4 times, most recently
from
July 11, 2024 18:31
0aaffac
to
f6af0af
Compare
jakim929
force-pushed
the
07-09-feat_print_available_accounts_on_startup
branch
from
July 11, 2024 18:32
f6af0af
to
916a2a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10
overview
hd_account_store.go
startup now looks like