-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(orchestrator): create orchestrator package #43
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @tremarkley and the rest of your teammates on Graphite |
72c019f
to
42706a0
Compare
func (o *Orchestrator) WaitUntilReady() error { | ||
var once sync.Once | ||
var err error | ||
ctx, cancel := context.WithCancel(context.Background()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should consider adding a timeout at all https://pkg.go.dev/context#WithTimeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitaliano I think for now we dont need one since this is only waiting on anvil instances to be ready, and that wait function already has a timeout in it:
Line 204 in e556e6e
timeoutCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! I'm starting to think you've been writing go longer than you're saying 😄
dcf29b3
to
c33a48e
Compare
c33a48e
to
e556e6e
Compare
Closes #6
Creates the
orchestrator
package with the following properties:orchestrator
spins up a default configuration of chainssupersim
package to useorchestrator
and moves all startup code forop-simulator
andanvil
into theorchestrator
package